Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove newline from echo confirmation on todo rm #176

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TiredSounds
Copy link

Seemed to be unintentional as -n is used in other places in the script when getting input.

@karbassi karbassi added this to the Version 2.12.0 milestone Mar 26, 2018
Copy link
Member

@inkarkat inkarkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two y/n confirmations both do not use -n, only the queries for data do. I'm not against changing this, but it should be applied to both (and likely extracted into a confirm() function).

@karbassi
Copy link
Member

karbassi commented Aug 6, 2021

@TiredSounds could you update the code to also include -n on line 1280?

todo.txt-cli/todo.sh

Lines 1279 to 1281 in 8d83ff6

if [ $TODOTXT_FORCE = 0 ]; then
echo "Move '$todo' from $src to $dest? (y/n)"
read ANSWER

echo "Move '$todo' from $src to $dest? (y/n)"

to

echo -n "Move '$todo' from $src to $dest? (y/n)"

@chrysle
Copy link
Contributor

chrysle commented Mar 5, 2023

Should this be closed or can maintainers make the requested changes?

@inkarkat
Copy link
Member

inkarkat commented Mar 5, 2023

There's a fix pending at inkarkat@4662651

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants